[PATCH] gdbserver: convert program_args to a single string

Tom Tromey tom@tromey.com
Tue Jan 14 17:23:48 GMT 2025


>>>>> "Simon" == Simon Marchi <simark@simark.ca> writes:

>> /* Start a new process.
>> PROGRAM is the program name.
>> -   PROGRAM_ARGS is the vector containing the inferior's args.
>> +   PROGRAM_ARGS is a string containing all the inferior's arguments.
>> Returns the new PID on success, -1 on failure.  Registers the new
>> process with the process list.  */

Simon> I think this comment should just be removed, there's no point in
Simon> repeating the documentation from the base class.

FWIW I normally consider the "override" keyword to be sufficient
documentation in these cases; though there's also some code with a
comment pointing at the base class.

Tom


More information about the Gdb-patches mailing list