[PATCH v2 7/8] gdbserver: remove the static_tracepoint enum value

[Aktemur, Tankut Baris]

On Tuesday, January 14, 2025 5:49 AM, Simon Marchi wrote:
> On 2025-01-10 11:01, Tankut Baris Aktemur wrote:
> > @@ -2455,8 +2415,10 @@ cmd_qtdp (char *own_buf)
> >  	    }
> >  	  else if (*packet == 'S')
> >  	    {
> > -	      tpoint->type = static_tracepoint;
> > -	      ++packet;
> > +	      trace_debug ("Tracepoint error: static tracepoints"
> > +			   " not supported");
> 
> I suppose that a well-behaving client would not send an 'S' flag if the
> remote has not advertised support for `StaticTracepoints+`, so I would
> just remove this "else if" entirely, letting the "else" handle it.
> 
> Looking at the GDB code, the use of the 'S' flag is guarded by
> `remote_supports_static_tracepoints()`, which checks for
> `StaticTracepoints+`.

Thank you.  I removed the 'else-if' completely and added the following
to the commit message:

  The handling of the 'S' option, where the `static_tracepoint` enum
  value was being used, is removed completely, because recognizing that
  option makes sense only when static tracepoint support is announced.

> 
> Other than that:
> 
> Approved-By: Simon Marchi <simon.marchi@efficios.com>
> 
> Simon

Baris
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Sean Fennelly, Jeffrey Schneiderman, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928