[PATCH v2 7/8] gdbserver: remove the static_tracepoint enum value

[Simon Marchi]

On 2025-01-10 11:01, Tankut Baris Aktemur wrote:
> @@ -2455,8 +2415,10 @@ cmd_qtdp (char *own_buf)
>  	    }
>  	  else if (*packet == 'S')
>  	    {
> -	      tpoint->type = static_tracepoint;
> -	      ++packet;
> +	      trace_debug ("Tracepoint error: static tracepoints"
> +			   " not supported");

I suppose that a well-behaving client would not send an 'S' flag if the
remote has not advertised support for `StaticTracepoints+`, so I would
just remove this "else if" entirely, letting the "else" handle it.

Looking at the GDB code, the use of the 'S' flag is guarded by
`remote_supports_static_tracepoints()`, which checks for
`StaticTracepoints+`.

Other than that:

Approved-By: Simon Marchi <simon.marchi@efficios.com>

Simon