[PATCH 3/3] gdb/mi: include ranges in =library-unloaded event

Eli Zaretskii eliz@gnu.org
Mon Jan 13 17:20:17 GMT 2025


> From: Andrew Burgess <aburgess@redhat.com>
> Cc: gdb-patches@sourceware.org
> Date: Mon, 13 Jan 2025 16:54:21 +0000
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> >> From: Andrew Burgess <aburgess@redhat.com>
> >> Cc: Andrew Burgess <aburgess@redhat.com>
> >> Date: Tue, 24 Dec 2024 12:05:37 +0000
> >> 
> >>  gdb/NEWS                            | 12 ++++++++++++
> >>  gdb/doc/gdb.texinfo                 | 20 +++++++++++++++-----
> >>  gdb/mi/mi-interp.c                  | 24 ++++++++++++++++--------
> >>  gdb/testsuite/gdb.mi/mi-dlmopen.exp | 15 ++++++++++++++-
> >>  4 files changed, 57 insertions(+), 14 deletions(-)
> >
> > Thanks.
> >
> >> --- a/gdb/NEWS
> >> +++ b/gdb/NEWS
> >> @@ -110,6 +110,18 @@
> >>  
> >>    ** The "variables" request will not return artificial symbols.
> >>  
> >> +* MI changes
> >> +
> >> +** The =library-unloaded event now includes the 'ranges' field, which
> >> +   has the same meaning as for the =library-loaded event.
> >> +
> >> +** The =library-unloaded event now includes the 'still-in-use' field.
> >> +   This field is 'true' when a library is unloaded (removed from the
> >> +   inferior's list of loaded libraries), but the mapping within the
> >> +   inferior's address space is retained, as the library was mapped
> >> +   multiple times, and the same mapping was being reused.  In all
> >> +   other cases, this field will have the value 'false'.
> >> +
> >>  * New commands
> >
> > This part is okay.
> >
> > The documentation parts are approved with these nits fixed.
> >
> > Reviewed-By: Eli Zaretskii <eliz@gnu.org>
> 
> Hi Eli!
> 
> Just got back around to this patch after the Christmas / New Year
> break.  I notice you mention fixing some nits ... but don't mention any
> nits :)
> 
> Is there something you'd like changed?

Sorry, I guess I pressed Send by mistake.

Yes, there are a couple of typos:

> +It is possible that a library can be appear multiple times in an
                                     ^^
That "be" should not be there.

> +inferior's address space.  When this happen, and one copy of the
                                        ^^^^^^
"happens"

Thanks.


More information about the Gdb-patches mailing list