[PATCH v2 4/6] Minor cleanup in linespec.c:add_minsym

Tom Tromey tom@tromey.com
Fri Jan 10 21:29:19 GMT 2025


This cleans up a 'return' in linespec.c:add_minsym.

Approved-By: Simon Marchi <simon.marchi@efficios.com>
---
 gdb/linespec.c | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/gdb/linespec.c b/gdb/linespec.c
index 09ce0d9df4a5f0f56137be99850988a670c5d68f..db979431002cc2048f9fcab52da0066793ef17c5 100644
--- a/gdb/linespec.c
+++ b/gdb/linespec.c
@@ -4122,11 +4122,8 @@ add_minsym (struct minimal_symbol *minsym, struct objfile *objfile,
     }
 
   /* Exclude data symbols when looking for breakpoint locations.  */
-  if (!list_mode && !msymbol_is_function (objfile, minsym))
-    return;
-
-  msyms->emplace_back (minsym, objfile);
-  return;
+  if (list_mode || msymbol_is_function (objfile, minsym))
+    msyms->emplace_back (minsym, objfile);
 }
 
 /* Search for minimal symbols called NAME.  If SEARCH_PSPACE

-- 
2.46.1



More information about the Gdb-patches mailing list