[PATCH RFC 0/2] Remove UST (static tracepoint) support from gdbserver

Simon Marchi simon.marchi@efficios.com
Thu Jan 9 16:17:57 GMT 2025


On 1/8/25 12:28 PM, Tankut Baris Aktemur wrote:
> Hello,
> 
> UST support in gdbserver is substantially outdated.  Simon suggested
> removing the support in a comment at
> 
>   https://inbox.sourceware.org/gdb-patches/f5fd16bf-1a2c-44d2-b777-73757fd8e6cd@efficios.com/
> 
> This is an RFC that aims to start that removal.  I wanted to make this
> an RFC to collect feedback on "how much" to remove.  In one further
> step, we can also remove the `static_tracepoint` enum in
> gdbserver/tracepoint.cc and all the relevant places where it's used.
> I think it makes sense to keep the related GDB commands and the RSP
> support unchanged.  Removing support from gdbserver doesn't mean that
> GDB would not be connected to a (downstream) stub that uses the
> feature or that the support would not be resurrected in the future.

This looks good to me, but I think you should go ahead and remove the
static_tracepoint enumerator and all associated code.  I think you can
also remove:

 - the handling of packets qTfSTM, qTsSTM and qTSTMat in tracepoint.cc
 - the handle_qxfer_statictrace function in server.cc

I agree that there is no rush of removing the GDB-side code, it's not in
your way like the code in GDBserver is.

Simon


More information about the Gdb-patches mailing list