[PATCH] gdb: boolify thread_info's 'stop_requested' field
Tankut Baris Aktemur
tankut.baris.aktemur@intel.com
Thu Jan 9 08:59:20 GMT 2025
Boolify the field. The 'set_stop_requested' function was already
taking a bool parameter, whose value is assigned to the field.
---
gdb/gdbthread.h | 2 +-
gdb/infcmd.c | 2 +-
gdb/infrun.c | 8 ++++----
3 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/gdb/gdbthread.h b/gdb/gdbthread.h
index 174488c083e..ee62153551f 100644
--- a/gdb/gdbthread.h
+++ b/gdb/gdbthread.h
@@ -533,7 +533,7 @@ class thread_info : public intrusive_list_node<thread_info>,
struct target_waitstatus pending_follow;
/* True if this thread has been explicitly requested to stop. */
- int stop_requested = 0;
+ bool stop_requested = false;
/* The initiating frame of a nexting operation, used for deciding
which exceptions to intercept. If it is null_frame_id no
diff --git a/gdb/infcmd.c b/gdb/infcmd.c
index 9fcbadbe023..b6b21a46b3d 100644
--- a/gdb/infcmd.c
+++ b/gdb/infcmd.c
@@ -2880,7 +2880,7 @@ stop_current_target_threads_ns (ptid_t ptid)
all-stop mode, we will only get one stop event --- it's undefined
which thread will report the event. */
set_stop_requested (current_inferior ()->process_target (),
- ptid, 1);
+ ptid, true);
}
/* See inferior.h. */
diff --git a/gdb/infrun.c b/gdb/infrun.c
index 8a10119487c..4687ee6edb3 100644
--- a/gdb/infrun.c
+++ b/gdb/infrun.c
@@ -1287,7 +1287,7 @@ follow_exec (ptid_t ptid, const char *exec_file_target)
/* The user may have had the main thread held stopped in the
previous image (e.g., schedlock on, or non-stop). Release
it now. */
- th->stop_requested = 0;
+ th->stop_requested = false;
update_breakpoints_after_exec ();
@@ -3091,7 +3091,7 @@ clear_proceed_status_thread (struct thread_info *tp)
tp->control.step_stack_frame_id = null_frame_id;
tp->control.step_over_calls = STEP_OVER_UNDEBUGGABLE;
tp->control.step_start_function = nullptr;
- tp->stop_requested = 0;
+ tp->stop_requested = false;
tp->control.stop_step = 0;
@@ -5497,7 +5497,7 @@ handle_one (const wait_one_event &event)
if (t == nullptr)
t = add_thread (event.target, event.ptid);
- t->stop_requested = 0;
+ t->stop_requested = false;
t->set_executing (false);
t->set_resumed (false);
t->control.may_range_step = 0;
@@ -5737,7 +5737,7 @@ stop_all_threads (const char *reason, inferior *inf)
infrun_debug_printf (" %s executing, need stop",
t->ptid.to_string ().c_str ());
target_stop (t->ptid);
- t->stop_requested = 1;
+ t->stop_requested = true;
}
else
{
--
2.34.1
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Sean Fennelly, Jeffrey Schneiderman, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928
More information about the Gdb-patches
mailing list