[PATCH] gdb/windows: remove disable_breakpoints_in_shlibs call
Andrew Burgess
aburgess@redhat.com
Tue Feb 25 09:27:41 GMT 2025
Tom Tromey <tom@tromey.com> writes:
>>>>>> "Andrew" == Andrew Burgess <aburgess@redhat.com> writes:
>
> Andrew> I think it should be safe to remove the disable_breakpoints_in_shlibs
> Andrew> call from windows_nat_target::do_initial_windows_stuff. There should
> Andrew> be no user visible changes.
>
> I agree.
> Approved-By: Tom Tromey <tom@tromey.com>
>
> Andrew> Testing for this change has been minimal. My only Windows build
> Andrew> machine is not great, and I've never managed to get DejaGNU running in
> Andrew> that environment. This commit builds, and a few basic, manual tests
> Andrew> seem fine, but beyond that, this change is untested.
>
> I have the same issue. I think it's fine to go ahead. If there are
> issues perhaps they'll be caught by the AdaCore test suite next week.
> However, I doubt that there will be.
Thanks. I'll go ahead and push this. If anything does show up, feel
free to go ahead and revert this change.
Thanks,
Andrew
More information about the Gdb-patches
mailing list