[PING][PATCH v2 0/1] gdbserver: add thread map

Rohr, Stephan stephan.rohr@intel.com
Wed Sep 25 06:57:57 GMT 2024


Hi all,

kindly pinging on this patch.

I appreciate your review.

Thanks
Stephan

> -----Original Message-----
> From: Rohr, Stephan <stephan.rohr@intel.com>
> Sent: Thursday, 12 September 2024 10:49
> To: gdb-patches@sourceware.org
> Cc: aburgess@redhat.com
> Subject: [PING][PATCH v2 0/1] gdbserver: add thread map
> 
> Hi all,
> 
> Just sending a ping on this patch.
> 
> Thanks
> Stephan
> 
> > -----Original Message-----
> > From: Stephan Rohr <stephan.rohr@intel.com>
> > Sent: Tuesday, 3 September 2024 13:35
> > To: gdb-patches@sourceware.org
> > Cc: aburgess@redhat.com
> > Subject: [PATCH v2 0/1] gdbserver: add thread map
> >
> > Hi all,
> >
> > this is version 2 of my patch that adds a process specific thread map
> > to gdbserver to support a fast lookup of threads based on the ptid,
> > similar to the implementation on GDB side.
> >
> > Changes based on v1 of the patch:
> >
> >   - Fixed a small typo in 'gdbthread.h'.
> >   - The process specific thread list and map are now private.  I added
> >     getters where necessary.
> >
> > I did not add an abstract all-threads iterator as suggested in the first
> > review as individual implementations for GDB and gdbserver for the
> > 'initialize' and 'advance' methods are required.  Thus, I don't see much
> > benefit in adding an abstract all threads iteartor at this point.
> >
> > You can find v1 of this patch at:
> > https://sourceware.org/pipermail/gdb-patches/2024-July/210378.html
> >
> > The feedback for v1 can be found at:
> > https://sourceware.org/pipermail/gdb-patches/2024-July/210608.html
> >
> > I appreciate your feedback.
> >
> > Thanks
> > stephan
> >
> > Stephan Rohr (1):
> >   gdbserver: add process specific thread list and map.
> >
> >  gdbserver/gdbthread.h  | 146 +++++++++++++++++++++++++++++++-----
> --
> > ---
> >  gdbserver/inferiors.cc |  49 ++++++++++----
> >  gdbserver/inferiors.h  |  29 +++++++-
> >  gdbserver/server.cc    |  59 ++++++++++++++---
> >  4 files changed, 226 insertions(+), 57 deletions(-)
> >
> > --
> > 2.34.1
> >
> > Intel Deutschland GmbH
> > Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
> > Tel: +49 89 99 8853-0, www.intel.de
> > Managing Directors: Sean Fennelly, Jeffrey Schneiderman, Tiffany Doon Silva
> > Chairperson of the Supervisory Board: Nicole Lau
> > Registered Office: Munich
> > Commercial Register: Amtsgericht Muenchen HRB 186928
> 
> Intel Deutschland GmbH
> Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
> Tel: +49 89 99 8853-0, www.intel.de
> Managing Directors: Sean Fennelly, Jeffrey Schneiderman, Tiffany Doon Silva
> Chairperson of the Supervisory Board: Nicole Lau
> Registered Office: Munich
> Commercial Register: Amtsgericht Muenchen HRB 186928
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Sean Fennelly, Jeffrey Schneiderman, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928


More information about the Gdb-patches mailing list