[PATCH v6] Add an option with a color type.

Andrei Pikas gdb@mail.api.win
Sat Sep 14 18:06:47 GMT 2024


Hello. Thanks for the review.

>> +      int colors = tgetnum ((char *)"Co");
> I wonder if that cast is really needed any longer.

On my machine with Ubuntu 22.04 and libncurses-dev 6.3 there is no need 
to cast because of const char * in the signature of tgetnum.

But in many manuals on the Internet the signature is described as 
tgetnum(char *).

Since I can't test it on every supported OS with every curses 
implementation I would leave this cast as everywhere in the gdb sources.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://sourceware.org/pipermail/gdb-patches/attachments/20240914/4a7722de/attachment.htm>


More information about the Gdb-patches mailing list