[PATCH 3/5] [gdb/symtab] Revert "Change handling of DW_TAG_enumeration_type in DWARF scanner"

Tom Tromey tom@tromey.com
Fri Sep 13 19:11:06 GMT 2024


>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:

Tom> Reverting the commit begs the question: what was it trying to fix in the first
Tom> place, and do we need a different fix?  I've investigated this and filed
Tom> PR32160 to track this.

Tom> My guess is that the commit was based on a misunderstand of what we track
Tom> in cooked_indexer::m_die_range_map.

It's been a while but my recollection is that, if you examine the DIE
range map while the cooked index is being built, you'll see entries in
it that are wrong -- they attribute the wrong context offset to a DIE
range.

I don't really recall any more than that.

Tom> +	    DW_TAG_enumeration_type {
Tom> +		{DW_AT_specification :$forward}
Tom> +	    } {

Ugh DWARF.

Anyway I didn't really understand why the backout patch adds a new test,
but I suppose it's not important.

Approved-By: Tom Tromey <tom@tromey.com>

Tom


More information about the Gdb-patches mailing list