[PATCH] gdb: change type of `general_symbol_info::m_section` to int

Simon Marchi simon.marchi@efficios.com
Thu Sep 12 14:42:45 GMT 2024


On 9/12/24 9:28 AM, Keith Seitz wrote:
> On 9/12/24 5:27 AM, Simon Marchi wrote:
>> It seems like the problem is just that the type used for the section
>> index (short) is not big enough.  Change from short to int.  If somebody
>> insists, we could even go long long / int64_t, but I doubt it's
>> necessary.
> 
> Amazingly, everywhere I looked where set_section_index was used ALREADY
> used/assumed `int'! Nice catch!

Cool, I hadn't checked them all, thanks for doing it.

>> With that fixed, I get:
>>
>>      (gdb) info func
>>      All defined functions:
>>
>>      Non-debugging symbols:
>>      0xffffffff81000000  _stext
>>      0xffffffff82257000  _sinittext
>>      0xffffffff822b4ebb  _einittext
>>
>> [1] https://sourceware.org/bugzilla/show_bug.cgi?id=32165
> 
> Reviewed-by: Keith Seitz <keiths@redhat.com>

Thanks,

Simon


More information about the Gdb-patches mailing list