[PATCH 3/7] btrace: Enable event tracing on Linux for Intel PT.

[Willgerodt, Felix]

> -----Original Message-----
> From: Eli Zaretskii <eliz@gnu.org>
> Sent: Montag, 2. September 2024 14:11
> To: Willgerodt, Felix <felix.willgerodt@intel.com>
> Cc: gdb-patches@sourceware.org; Metzger, Markus T
> <markus.t.metzger@intel.com>
> Subject: Re: [PATCH 3/7] btrace: Enable event tracing on Linux for Intel PT.
> 
> > Date: Mon, 02 Sep 2024 15:09:12 +0300
> > From: Eli Zaretskii <eliz@gnu.org>
> > Cc: gdb-patches@sourceware.org, markus.t.metzger@intel.com
> >
> > > From: Felix Willgerodt <felix.willgerodt@intel.com>
> > > Date: Mon,  2 Sep 2024 13:49:45 +0200
> > >
> > > Event tracing allows GDB to show information about interesting asyncronous
> >                                                                  ^^^^^^^^^^^
> > Typo.
> >
> > >  gdb/doc/gdb.texinfo          | 41 +++++++++++++++++++++++++----
> > >  gdb/features/btrace-conf.dtd |  1 +
> > >  gdb/nat/linux-btrace.c       | 11 ++++++++
> > >  gdb/record-btrace.c          | 44 +++++++++++++++++++++++++++++++
> > >  gdb/remote.c                 | 50 +++++++++++++++++++++++++++++++++++-
> > >  gdbserver/linux-low.cc       |  2 ++
> > >  gdbserver/server.cc          | 14 ++++++++++
> > >  gdbsupport/btrace-common.h   |  3 +++
> > >  8 files changed, 160 insertions(+), 6 deletions(-)
> >
> > Thanks, the documentation parts are OK.
> 
> Actually, one question: should this be mentioned in NEWS?

Hi Eli,

Thanks for the review, I have fixed the typo locally. And yes, this probably warrants
a NEWS entry. I have written this now in my local branch:

diff --git a/gdb/NEWS b/gdb/NEWS
index 2f5d5ebbcef..8f45593cf02 100644
--- a/gdb/NEWS
+++ b/gdb/NEWS
@@ -3,6 +3,11 @@
 
 *** Changes since GDB 15
 
+* GDB now supports printing of asynchronous events from the Intel Processor
+  Trace during 'record instruction-history', 'record function-call-history'
+  and all stepping commands.  This can be controlled with the new
+  "set record btrace pt event-tracing" command.
+
 * GDB now supports printing of ptwrite payloads from the Intel Processor
   Trace during 'record instruction-history', 'record function-call-history'
   and all stepping commands.  The payload is also accessible in Python as a

Regards,
Felix

Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Sean Fennelly, Jeffrey Schneiderman, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928