[PATCH] [gdb] Handle EINTR in run_under_shell

[Tom de Vries]

On 10/21/24 19:44, Tom Tromey wrote:
>>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
> 
> Tom> Fix this by using gdb::handle_eintr to call waitpid in run_under_shell.
> 
> Tom> Also handle the case that waitpid returns an error other than EINTR, using
> Tom> perror_with_name.
> 

Hi Tom,

thanks for the review, pushed.

> This seems fine but I wonder if the other calls to waitpid need this treatment.
> I see linux defines my_waitpid as wrapper... like, should that be used everywhere?
> 

I started to look at this, spent some time trying to rewrite the 
template because I didn't like the look of it, and then started 
wondering whether the loop needs to call QUIT or not.

I suppose it shouldn't matter, because for the automatic restart case we 
don't check it either.

I'll try to come up with a patch series.

Thanks,
- Tom

> Tom> PR gdb/30695
> Tom> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30695
> 
> Approved-By: Tom Tromey <tom@tromey.com>
> 
> Tom