[PATCH v4 00/22] Add a C++ hash table to gdbsupport
Tom Tromey
tom@tromey.com
Fri Oct 4 20:56:14 GMT 2024
>>>>> "Simon" == Simon Marchi <simon.marchi@efficios.com> writes:
Simon> This is v4 of:
Simon> https://inbox.sourceware.org/gdb-patches/5286ffda-15d0-4b26-95e0-46e1b32f5b0b@efficios.com/T/#mf6dcd72f0292c31ff566c9c971066692c154595f
I sent a few notes.
I find the new hash table itself completely unreadable. I don't look
forward to trying to debug it. Hopefully it won't happen.
Most of the series seems fine to me but there were a couple spots where
I think the transform is perhaps more expensive (in memory) than we'd
like.
Tom
More information about the Gdb-patches
mailing list