[PATCHv2] gdb/build-id: protect against weirdly short build-ids

[Kevin Buettner]

On Thu, 21 Nov 2024 14:29:05 +0000
Andrew Burgess <aburgess@redhat.com> wrote:

> In v2:
> 
>   - Print a debug message when a short build-id is ignored.  I did
>     consider a warning, but I wasn't sure if that was suitable or not.
>     In the end some debug output means we can at least diagnose why
>     the debug lookup failed.

I think this is fine.  I've worked on bugs in the past where GDB was
spamming the user with hundreds (or thousands...) of warnings.  If
we were to output a warning for this case, I think it'd be important
to make sure that it doesn't happen more than a few times per session.
In any case, I'm happy to see that you've provided a way to diagnose
the problem.

Approved-by: Kevin Buettner <kevinb@redhat.com>