[PATCH] gdb: make the error message for unreadable objfiles more informative

Guinevere Larsen guinevere@redhat.com
Thu Nov 7 19:57:08 GMT 2024


When GDB is unable to read an objfile, it prints the error message "I'm
sorry Dave, I can't do that. Symbol format `%s' unknown.". While it is a
great reference, an end user won't have much information about the
problem.

So far this wasn't much of a problem, as it is very uncommon for GDB to
be unable to read an objfile. However, a future patch will allow users
to selectively disable support to some formats, making it somewhat
expected that the message will be seen by end users.

This commit makes the end message more informative and direct.
---
 gdb/symfile.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gdb/symfile.c b/gdb/symfile.c
index 1502fdbe500..adc60e1b723 100644
--- a/gdb/symfile.c
+++ b/gdb/symfile.c
@@ -1775,8 +1775,8 @@ find_sym_fns (bfd *abfd)
     if (our_flavour == rsf.sym_flavour)
       return rsf.sym_fns;
 
-  error (_("I'm sorry, Dave, I can't do that.  Symbol format `%s' unknown."),
-	 bfd_get_target (abfd));
+  error (_("Object file %s could not be read.  Symbol format `%s' unknown."),
+	 abfd->filename, bfd_get_target (abfd));
 }
 
 
-- 
2.47.0



More information about the Gdb-patches mailing list