[PATCH] gdb/doc: use silent-rules.mk in the Makefile

[Andrew Burgess]

Joel Brobecker <brobecker@adacore.com> writes:

> Hi Andrew,
>
>> > commit 13baf7f097593b9d877036f55fb3d9c2d443ea38
>> > Author: Andrew Burgess <aburgess@redhat.com>
>> > Date:   Fri Apr 12 17:47:20 2024 +0100
>> >
>> >     gdb/doc: use silent-rules.mk in the Makefile
>
> I think this patch unfortunately broke the install phase of the doc
> when building from a source package. To reproduce, first create
> a tarball file by executing the following command from the root
> of the binutils-gdb repository:
>
>     $ ./src-release.sh gdb
>
> This will create a .tar file at the root of the repository
> (and it creates a lot of other files, so you want to do this in
> a copy of your repository, if you don't want to have to deal
> with the pollution)
>
> Then, from a separate directory, first unpack the tarball sources.
> And then, create a local build directory, and from that directory,
> configure and build GDB - I did:
>
>     $ CFLAGS='-g' CXXFLAGS='-g' ../gdb-15.0.50.20240508/configure --prefix=/[...]/ins
>     $ make -j8
>
> Once you've done that, try...
>
>     $ make install
>
> ... and you should see the error I'm getting:
>
>     | [...]
>     |   TEXI2POD gdb.pod
>     | cannot find GDBvn.texi at ../../../gdb-15.0.50.20240508/gdb/doc/../../etc/texi2pod.pl line 251, <GEN0> line 16.
>     | make[5]: *** [Makefile:663: gdb.pod] Error 2
>
> I don't know what the root of the problem is, but I think one thing
> that is happening now that should not be happening is the fact that
> (I think) it is trying to re-generate the gdb.1 man page, whereas
> gdb.1 is already present in the sources. With the gdb-14.2 release,
> from what I've seen, the install simply consists in copying gdb.1
> from source dir to install dir.
>
> Do you think you could take a look? And once we have a fix, could you
> backport it to the gdb-15-branch? I think we'll want the fix in that
> branch before we create the first pre-release.

I'm investigating this now.

Thanks,
Andrew

>
> Thank you!
> -- 
> Joel