[PATCH v7 03/10] gdb: handle stepping through functions with DW_AT_trampoline

[Ijaz, Abdul B]

Hi Eli,

Thanks for the feedback.

>> +some compilers might generate so-called trampoline functions, which 
>> +wrap the actual function call (the
             ^^^^^^^^^^^^^^^^^^^^
>In the previous review, I suggested to have "trampoline functions"
>here in @dfn, since this introduces new terminology.  I don't see that in this version.

I update it only in the NEWS part in v7 and missed the gdb.textinfo part. Now preparing the Patch v8 to fix it also.

Best Regards
Abdul Basit

-----Original Message-----
From: Eli Zaretskii <eliz@gnu.org> 
Sent: Friday, May 24, 2024 1:06 PM
To: Ijaz, Abdul B <abdul.b.ijaz@intel.com>
Cc: gdb-patches@sourceware.org; JiniSusan.George@amd.com; tom@tromey.com; nils-christian.kempke@intel.com
Subject: Re: [PATCH v7 03/10] gdb: handle stepping through functions with DW_AT_trampoline

> From: Abdul Basit Ijaz <abdul.b.ijaz@intel.com>
> Cc: abdul.b.ijaz@intel.com,
> 	JiniSusan.George@amd.com,
> 	tom@tromey.com,
> 	eliz@gnu.org,
> 	Nils-Christian Kempke <nils-christian.kempke@intel.com>
> Date: Fri, 24 May 2024 11:16:06 +0200
> 
> diff --git a/gdb/NEWS b/gdb/NEWS
> index 691abff420b..b435553d23a 100644
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -912,6 +912,17 @@ platform.
>  
>  * New commands
>  
> +set skip-trampoline-functions on|off
> +show skip-trampoline-functions
> +  This setting is 'on' by default.  When 'on' it controls whether GDB 
> +will
> +  recognize function calls that have been marked as trampolines in 
> +the debug
> +  info.  It improves stepping behavior in that it steps over the 
> +trampoline
> +  code and hides it from the user.  Currently, only DWARF trampolines 
> +are
> +  supported.
> +
> +  If this is turned off, GDB will handle @dfn{trampoline functions} 
> + the same  as any other function.

This part is OK.

> +@kindex set skip-trampoline-functions @item set 
> +skip-trampoline-functions @cindex trampoline functions @cindex 
> +stepping through trampoline functions @itemx set 
> +skip-trampoline-functions on When calling a function in any language, 
> +some compilers might generate so-called trampoline functions, which 
> +wrap the actual function call (the
             ^^^^^^^^^^^^^^^^^^^^
In the previous review, I suggested to have "trampoline functions"
here in @dfn, since this introduces new terminology.  I don't see that in this version.

> +  add_setshow_boolean_cmd ("skip-trampoline-functions", class_run,
> +			  &skip_trampoline_functions, _("\ Set whether gdb attempts to 
> +hide trampolines marked in the debug info."), _("\ Show whether gdb 
> +attempts to hide trampolines marked in the debug info."), _("\ If on, 
> +while stepping gdb will skip through functions and inlined 
> +functions\n\ marked as trampolines by the compiler.  If off, gdb will 
> +treat trampolines as\n\ normal functions."),
> +			  nullptr, show_skip_trampoline_functions, &setlist,
> +			  &showlist);
> +
>    /* Set/show detach-on-fork: user-settable mode.  */

This part is okay.

Thanks.

Reviewed-By: Eli Zaretskii <eliz@gnu.org>
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Sean Fennelly, Jeffrey Schneiderman, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928