[PATCHv5 02/11] gdbserver: convert have_ptrace_getregset to a tribool

Andrew Burgess aburgess@redhat.com
Tue May 7 15:28:00 GMT 2024


"Willgerodt, Felix" <felix.willgerodt@intel.com> writes:

>> -----Original Message-----
>> From: Andrew Burgess <aburgess@redhat.com>
>> Sent: Freitag, 26. April 2024 17:02
>> To: gdb-patches@sourceware.org
>> Cc: Andrew Burgess <aburgess@redhat.com>; Willgerodt, Felix
>> <felix.willgerodt@intel.com>; John Baldwin <jhb@FreeBSD.org>
>> Subject: [PATCHv5 02/11] gdbserver: convert have_ptrace_getregset to a tribool
>> 
>> Convert the have_ptrace_getregset global within gdbserver to a
>> tribool.  This brings the flag into alignment with the corresponding
>> flag in GDB.
>> 
>> The gdbserver have_ptrace_getregset variable is already used as a
>> tribool, it just doesn't have the tribool type.
>> 
>> In a future commit I plan to share more code between GDB and
>> gdbserver, and having this variable be the same type in both code
>> bases will make the sharing much easier.
>> 
>> There should be no user visible changes after this commit.
>> 
>> Approved-By: John Baldwin <jhb@FreeBSD.org>
>> ---
>>  gdbserver/linux-arm-low.cc |  6 +++---
>>  gdbserver/linux-low.cc     |  2 +-
>>  gdbserver/linux-low.h      |  2 +-
>>  gdbserver/linux-x86-low.cc | 10 +++++-----
>>  4 files changed, 10 insertions(+), 10 deletions(-)
>
>
> Reviewed-By: Felix Willgerodt <felix.willgerodt@intel.com>
>
> Looks fine to me, x86 parts are approved.

I've also pushed this patch from this series as it's only loosely
related to the rest of the series.

Thanks,
Andrew



More information about the Gdb-patches mailing list