[PATCH v2 3/3] Add symbol, line, and location to DAP disassemble result

Tom Tromey tromey@adacore.com
Fri May 3 15:46:57 GMT 2024


>>>>> "Tom" == Tom Tromey <tromey@adacore.com> writes:

Tom> The DAP spec allows a number of attributes on the resulting
Tom> instructions that gdb currently does not emit.  A user requested some
Tom> of these, so this patch adds the 'symbol', 'line', and 'location'
Tom> attributes.  While the spec lets the implementation omit 'location' in
Tom> some cases, it was simpler in the code to just always emit it, as then
Tom> no extra tracking was needed.

Tom> +            if sal.line != 0:
Tom> +                result["line"] = str(sal.line)

A co-worker noticed that this is emitting a string instead of a number,
contrary to the spec.  I've fixed this locally.

Tom


More information about the Gdb-patches mailing list