[PATCH v3] [RFC] Fix AIX thread exit events not being reported and UI to show kernel thread ID.

Ulrich Weigand Ulrich.Weigand@de.ibm.com
Thu May 2 16:30:27 GMT 2024


Aditya Vidyadhar Kamath <akamath996@gmail.com> wrote:

>+  /* Describes the number of thread exit events reported.  */
>+  std::unordered_set<pthdb_pthread_t> exited_threads;
>+
>+  /* Describes if thread is still in queue and not in unknown state.  */
>+  std::vector<pthdb_pthread_t> in_queue_threads;

I don't really like these new global variables.  exited_threads
seems to be only ever added to, so it will just keep growing
forever?  in_queue_threads seems to be fully local to the
sync_threadlists routine, so why is it not just a local
variable there?

As a more general question, I'm wondering why you're completely
changing the way sync_threadlists works.  I think the overall
idea of sync_threadslists, i.e. to compare the thread list of
the OS with GDB's thread list and then update the latter to
match the former, is still valid.  I thought you'd simply change
the way the "pbuf" list is generated to filter out those threads
that the OS considers in terminated state.

Bye,
Ulrich



More information about the Gdb-patches mailing list