[PATCH] [gdb/testsuite] Add missing include in gdb.base/rtld-step.exp

Tom de Vries tdevries@suse.de
Fri Mar 29 10:48:11 GMT 2024


On 3/28/24 18:26, John Baldwin wrote:
> On 3/27/24 12:23 PM, Tom de Vries wrote:
>> On fedora rawhide, with test-case gdb.base/rtld-step.exp I get:
>> ...
>> static-pie-static-libc.c: In function '_start':^M
>> static-pie-static-libc.c:1:22: error: \
>>    implicit declaration of function '_exit' 
>> [-Wimplicit-function-declaration]^M
>>      1 | void _start (void) { _exit (0); }^M
>>        |                      ^~~~~^M
>> compiler exited with status 1
>>    ...
>> UNTESTED: gdb.base/rtld-step.exp: failed to compile \
>>    (-static-pie not supported or static libc missing)
>> ...
>>
>> Fix this by adding the missing include.
>>
>> Tested on aarch64-linux.
> 
> Approved-By: John Baldwin <jhb@FreeBSD.org>
> 

Hi John,

thanks for the review.

I had already committed after the approval of Kevin, so unfortunately 
this was committed without your approved-by tag.

Thanks,
- Tom


More information about the Gdb-patches mailing list