[PATCH v2 4/4] gdb, gdbserver, gdbsupport: remove includes of early headers

Pedro Alves pedro@palves.net
Tue Mar 26 11:59:16 GMT 2024


On 2024-03-23 02:14, Simon Marchi wrote:
> Now that defs.h, server.h and common-defs.h are included via the
> `-include` option, it is no longer necessary for source files to include
> it.  Remove all the inclusions of these files I could find.  Update the
> generation scripts where relevant.
> 

I didn't try to apply the patch locally to confirm, but (given the previous patch) AFAICS
this leaves behind at least the common-defs.h include in gdbreplay.cc, right?  Any others left behind? 

For any that need to be kept in place, it would be nice to see them called out in the commit log,
and to add a comment above the left-behind #include explaining why it exists.



More information about the Gdb-patches mailing list