[PATCH v11 06/10] python: Add clear() to gdb.Record.

Willgerodt, Felix felix.willgerodt@intel.com
Thu Jul 25 12:13:46 GMT 2024


> -----Original Message-----
> From: Eli Zaretskii <eliz@gnu.org>
> Sent: Donnerstag, 25. Juli 2024 13:01
> To: Willgerodt, Felix <felix.willgerodt@intel.com>
> Cc: gdb-patches@sourceware.org; Metzger, Markus T
> <markus.t.metzger@intel.com>
> Subject: Re: [PATCH v11 06/10] python: Add clear() to gdb.Record.
> 
> > From: Felix Willgerodt <felix.willgerodt@intel.com>
> > Date: Thu, 25 Jul 2024 11:09:33 +0200
> >
> > This function allows to clear the trace data from python, forcing to
> > re-decode the trace for successive commands.
> > This will be used in future ptwrite patches, to trigger re-decoding when
> > the ptwrite filter changes.
> >
> > Reviewed-By: Eli Zaretskii <eliz@gnu.org>
> > Approved-By: Markus Metzger <markus.t.metzger@intel.com>
> > ---
> >  gdb/NEWS                                      |  5 +++++
> >  gdb/doc/python.texi                           |  5 +++++
> >  gdb/python/py-record-btrace.c                 | 13 +++++++++++++
> >  gdb/python/py-record-btrace.h                 |  3 +++
> >  gdb/python/py-record.c                        | 16 ++++++++++++++++
> >  gdb/testsuite/gdb.python/py-record-btrace.exp |  4 ++++
> >  6 files changed, 46 insertions(+)
> 
> Thanks.
> 
> > diff --git a/gdb/NEWS b/gdb/NEWS
> > index 9a5543c0443..4ab6cc92edf 100644
> > --- a/gdb/NEWS
> > +++ b/gdb/NEWS
> > @@ -3,6 +3,11 @@
> >
> >  *** Changes since GDB 15
> >
> > +* Python API
> > +
> > +  ** Added gdb.record.clear(). Clears the trace data of the current recording.
>                                 ^^
> Two spaces there.  And I also wonder whether we need the "()" part.

I fixed the spaces and removed the "()" locally. Though other functions in the NEWS
File are also described with a "()". To show that these are functions.

Thanks,
Felix
Intel Deutschland GmbH
Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Sean Fennelly, Jeffrey Schneiderman, Tiffany Doon Silva
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928


More information about the Gdb-patches mailing list