[PATCH 05/46] gdb, arch, intelgt: add intelgt arch definitions

[Guinevere Larsen]

On 7/2/24 8:42 AM, Tankut Baris Aktemur wrote:
> From: Markus Metzger<markus.t.metzger@intel.com>
>
> Provide Intel GT architecture-specific definitions that can be used by
> both the low target at the server side and tdep at the GDB side.
>
> Other than, for example, IA, Intel GT does not have a dedicated
> breakpoint instruction.  Instead, it has a breakpoint bit in each
> instruction.  We define arch methods for dealing with instruction
> breakpoint bits.
>
> Co-authored-by: Tankut Baris Aktemur<tankut.baris.aktemur@intel.com>
> Co-authored-by: Mihails Strasuns<mihails.strasuns@intel.com>
> Co-authored-by: Natalia Saiapova<natalia.saiapova@intel.com>
> ---
>   gdb/arch/intelgt.c |  78 ++++++++++++++++++++
>   gdb/arch/intelgt.h | 175 +++++++++++++++++++++++++++++++++++++++++++++
>   2 files changed, 253 insertions(+)
>   create mode 100644 gdb/arch/intelgt.c
>   create mode 100644 gdb/arch/intelgt.h

I was just taking a quick look and noticed you added the .c and .h 
files, but didn't change the Makefile.in here (you add it in the next 
patch). shouldn't that change be moved to this patch?

-- 
Cheers,
Guinevere Larsen
She/Her/Hers
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://sourceware.org/pipermail/gdb-patches/attachments/20240703/3ae6f7ed/attachment.htm>