[PATCH] [gdb/dap] Fix exit race

Tom de Vries tdevries@suse.de
Wed Feb 14 15:39:43 GMT 2024


On 2/13/24 19:10, Tom Tromey wrote:
>>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
> 
> Tom> Fix this by removing the send_gdb("quit").
> 
> I thought you were sending a different patch for this?

This is the patch for PR31306, the assertion failure.

> I think this change by itself is insufficient because it might mean that
> gdb exits before all the queued responses are emitted.

As for PR31380, which is about ensuring responses are flushed to client 
before exiting, indeed there's a race between flushing the write queue 
and gdb exiting because of a SIGHUP (which is not caused by the 
send_gdb("quit"), I've mentioned that in the PR.

Thanks,
- Tom


More information about the Gdb-patches mailing list