[PATCH v5 4/4] Linux checkpoints: Update NEWS and gdb.texinfo regarding multiple inferiors
Eli Zaretskii
eliz@gnu.org
Tue Dec 10 13:04:15 GMT 2024
> From: Kevin Buettner <kevinb@redhat.com>
> Cc: pedro@palves.net,
> Kevin Buettner <kevinb@redhat.com>
> Date: Mon, 9 Dec 2024 18:54:07 -0700
>
> ---
> gdb/NEWS | 2 ++
> gdb/doc/gdb.texinfo | 20 +++++++++++++++++++-
> 2 files changed, 21 insertions(+), 1 deletion(-)
Thanks.
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -174,6 +174,8 @@ vFile:stat
> vFile:fstat but takes a filename rather than an open file
> descriptor.
>
> +* Linux checkpoint code has been updated to work with multiple inferiors.
> +
This part is okay.
> +Checkpoint IDs will be displayed as either a non-negative integer or
> +in the form @var{I}.@var{N}, where @var{I} is the inferior number, a
> +positive integer, as shown by the command @code{info inferiors}, and
> +@var{N}, a non-negative integer, is the checkpoint number for that
> +inferior. The single non-negative integer form is used when
> +there is only one inferior. The @var{I}.@var{N} form is used when
> +there are multiple inferiors.
Please always use lower-case letters inside @var. In Info format,
they are capitalized by makeinfo, but in other formats we get slanted
typeface which is much more pretty than upper-case.
> +The active state indicator is a single letter, either @code{y} or
> +@code{n}, indicating yes or no. Only one checkpoint per inferior may
> +be active at once. The active checkpoint in the current inferior is
> +also shown by a @code{*} at the start of the line. Checkpoints whose
> +active state is @code{n} can be switched to
Please use @samp for the indicators, not @code. These are not words,
so they will look strange without quotes in formats other than Info
(where makeinfo quotes them).
The gdb.texinfo part is okay with these nits fixed.
Reviewed-By: Eli Zaretskii <eliz@gnu.org>
More information about the Gdb-patches
mailing list