[PATCH] gdb/testsuite: Fix libc_has_debug_info when there's no libc
Thiago Jung Bauermann
thiago.bauermann@linaro.org
Tue Apr 30 02:07:36 GMT 2024
Hello Tom,
Tom Tromey <tom@tromey.com> writes:
>>>>>> "Thiago" == Thiago Jung Bauermann <thiago.bauermann@linaro.org> writes:
>
> Thiago> Fix by:
>
> Thiago> - always defining libc_has_debug_info and message with a default
> Thiago> value,
> Thiago> - adding a pattern for the case where there's no libc.so in the
> Thiago> inferior, and
> Thiago> - removing the default pattern, which doesn't serve a purpose anymore.
>
> Thiago> Also, remove a couple of verbose messages which aren't really useful
> Thiago> because they're redundant with the $message variable.
>
> Thanks. This looks reasonable to me.
> Approved-By: Tom Tromey <tom@tromey.com>
Thank you.
And thank you Bernd for testing the patch.
Though Pedro raised concerns about libc_has_debug_info:
https://inbox.sourceware.org/gdb-patches/b0409c48-7f9c-4430-91d9-dc7cfa86a9c7@palves.net/
So I just sent a new patch which is an alternative to this one:
https://inbox.sourceware.org/gdb-patches/20240430015325.89780-1-thiago.bauermann@linaro.org/
which restores the original behaviour and also fixes Bernd's reported
Tcl error.
--
Thiago
More information about the Gdb-patches
mailing list