[PATCH 1/7] gdb: move declarations of check_quit_flag and set_quit_flag to extension.h

Simon Marchi simon.marchi@polymtl.ca
Mon Apr 29 14:46:28 GMT 2024


On 4/25/24 4:52 AM, Alexandra Petlanova Hajkova wrote:
> 
> 
> On Tue, Apr 23, 2024 at 3:25 PM Simon Marchi <simon.marchi@polymtl.ca <mailto:simon.marchi@polymtl.ca>> wrote:
> 
>     Move them out of defs.h, to extension.h, since the implementations are
>     in extension.c.
> 
>     Change-Id: Ie7321468bd7fecc684d70b09f72c3ee8ac75d8f4
> 
> 
> This looks like a reasonable change and also it introduce no regressions on Fedora Rawhide aarch64.

Hi Alexandra,

Thanks for the review.  If you would like to get an acknowledgement for
your time spent reviewing or testing, you can reply with a tag such as:

Reviewed-By: Alexandra Petlanova Hajkova <ahajkova@redhat.com>

or

Tested-By: Alexandra Petlanova Hajkova <ahajkova@redhat.com>

You can also put both if you reviewed the code and did some testing.

The committer will then put these as git trailers in the commit message.

See: https://sourceware.org/gdb/wiki/ContributionChecklist#Receiving_positive_reviews

Simon


More information about the Gdb-patches mailing list