[PATCH] gdbsupport, gdbserver, gdb: use -Wno-vla-cxx-extension

Simon Marchi simark@simark.ca
Wed Apr 17 14:52:32 GMT 2024



On 2024-04-16 18:56, Tom Tromey wrote:
> Simon> Here's the list of those I see in my build (x86-64 Linux all targets):
> 
> Simon> I think we should have a vector type with "small vector optimization",
> Simon> it would be great to replace these uses of VLAs.  I might give it a shot
> Simon> at some point (or maybe someone else wants to try?).  But until then, I
> Simon> think it makes sense to silence the warning.
> 
> I suppose I'm ok with that.

Ok, pushed.  Whoever takes on the project of removing VLAs can remove
the flag.

> On the whole I'd prefer we remove VLAs (since they aren't standard) and
> alloca (since it is bad).  I don't really care if we have a small vector
> unless it's proven we need it.

Agreed.

Simon


More information about the Gdb-patches mailing list