Fix max-depth test case for AIX.

[Aditya Kamath1]

Respected Tom, Andrew and community members,

Hi,

Thank you for your feedback.

Please find attached a patch. (See: 0001-Fix-max-depth-test-case-for-AIX.patch)

Andrew> Given what the test is doing I don't think there's any need for the
Andrew> #ifdef, I'd suggest just adding a comment explaining why we need to
Andrew> ensure the variables are referenced, and reference them.

>Agreed.  Look for 'Do_Nothing' in the Ada tests to see how this is
>handled for Ada programs.  I feel like we've done something similar in
>some cases for C as well.

Thank you Tom. I referred the gdb.ada/varsize_limit/pck.adb file for the Do_nothing function.

package body Pck is
   procedure Do_Nothing (A : System.Address) is
   begin
      null;
   end Do_Nothing;
   function Ident (S : String) return String is
   begin
      return S;
   end Ident;
end Pck;

Here Do_nothing is doing nothing. Did something similar. Let me know if any changes needed.

Output in AIX after this patch is applied.

/current_gdb/binutils-gdb/gdb/gdb version  15.0.50.20240325-git -nw -nx -q -iex "set height 0" -iex "set width 0" -data-directory /current_gdb/binutils-gdb/gdb/data-directory

                === gdb Summary ===

# of expected passes            92
/current_gdb/binutils-gdb/gdb/gdb version  15.0.50.20240325-git -nw -nx -q -iex "set height 0" -iex "set width 0" -data-directory /current_gdb/binutils-gdb/gdb/data-directory

Have a nice day ahead.

Thanks and regards,
Aditya.


From: Tom Tromey <tom@tromey.com>
Date: Wednesday, 3 April 2024 at 8:28 PM
To: Andrew Burgess <aburgess@redhat.com>
Cc: Aditya Kamath1 <Aditya.Kamath1@ibm.com>, Ulrich Weigand <Ulrich.Weigand@de.ibm.com>, Aditya Kamath1 via Gdb-patches <gdb-patches@sourceware.org>, Sangamesh Mallayya <sangamesh.swamy@in.ibm.com>
Subject: [EXTERNAL] Re: Fix max-depth test case for AIX.
Andrew> Given what the test is doing I don't think there's any need for the
Andrew> #ifdef, I'd suggest just adding a comment explaining why we need to
Andrew> ensure the variables are referenced, and reference them.

Agreed.  Look for 'Do_Nothing' in the Ada tests to see how this is
handled for Ada programs.  I feel like we've done something similar in
some cases for C as well.

Tom
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://sourceware.org/pipermail/gdb-patches/attachments/20240410/8901078a/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fix-max-depth-test-case-for-AIX.patch
Type: application/octet-stream
Size: 1223 bytes
Desc: 0001-Fix-max-depth-test-case-for-AIX.patch
URL: <https://sourceware.org/pipermail/gdb-patches/attachments/20240410/8901078a/attachment-0001.obj>