[PATCH 4/4] gdb/dap: only include sourceReference if file path does not exist
Gregory Anders
greg@gpanders.com
Fri Sep 1 21:42:59 GMT 2023
On Fri, 01 Sep 2023 13:42 -0600, Tom Tromey wrote:
>I suspect we should just remove all sourceReference handling from
>sources.py, because if we can't find a full path, gdb isn't going to be
>able to come up with the source anyway.
>
>What do you think?
I agree. I avoided doing this originally to keep the change small, but I
think eliminating sourceReference completely (for the reason you
mentioned) is the better approach. It will keep the code simpler.
>I thought the test suite might need some updates but I don't see any
>references to sourceReference there.
There was one test case that was failing with the v1 patch
(sources.exp). I updated it in v2 (sent a few minutes ago).
Greg
More information about the Gdb-patches
mailing list