[PATCH 2/4] Remove dead code from varobj_set_display_format

Tom Tromey tromey@adacore.com
Fri Sep 1 14:47:12 GMT 2023


varobj_set_display_format takes an enum and exhaustively switches on
the values -- but also has a default.  This default case is dead code.
---
 gdb/varobj.c | 15 +--------------
 1 file changed, 1 insertion(+), 14 deletions(-)

diff --git a/gdb/varobj.c b/gdb/varobj.c
index 52e62aca265..760809c6f51 100644
--- a/gdb/varobj.c
+++ b/gdb/varobj.c
@@ -488,20 +488,7 @@ enum varobj_display_formats
 varobj_set_display_format (struct varobj *var,
 			   enum varobj_display_formats format)
 {
-  switch (format)
-    {
-    case FORMAT_NATURAL:
-    case FORMAT_BINARY:
-    case FORMAT_DECIMAL:
-    case FORMAT_HEXADECIMAL:
-    case FORMAT_OCTAL:
-    case FORMAT_ZHEXADECIMAL:
-      var->format = format;
-      break;
-
-    default:
-      var->format = variable_default_display (var);
-    }
+  var->format = format;
 
   if (varobj_value_is_changeable_p (var) 
       && var->value != nullptr && !var->value->lazy ())

-- 
2.40.1



More information about the Gdb-patches mailing list