[PATCH 2/2] gdb/testsuite: tighten up some end-of-line patterns

Tom Tromey tom@tromey.com
Thu Nov 30 19:23:47 GMT 2023


>>>>> "Andrew" == Andrew Burgess <aburgess@redhat.com> writes:

Andrew> Following on from the previous commit, I searched the testsuite for
Andrew> places where we did:

Andrew>   set eol "<some pattern>"

Andrew> in most cases the <some pattern> could be replaced with "\r\n" though
Andrew> in the stabs test I've switched to using the multi_line proc as that
Andrew> seemed like a better choice.

Andrew> In gdb.ada/info_types.exp I did need to add an extra use of $eol as
Andrew> the previous pattern would match multiple newlines, and in this one
Andrew> place we were actually expecting to match multiple newlines.  The
Andrew> tighter pattern only matches a single newline, so we now need to be
Andrew> explicit when multiple newlines are expected -- I think this is a good
Andrew> thing.

Andrew> All the tests are still passing for me after these changes.

Looks good to me, thank you.
Approved-By: Tom Tromey <tom@tromey.com>

Tom


More information about the Gdb-patches mailing list