[PATCHv2 4/5] gdb/gdbarch: remove the 'invalid=None' state from gdbarch_components.py

Simon Marchi simark@simark.ca
Tue Mar 7 15:20:12 GMT 2023



On 3/7/23 10:17, Tom Tromey wrote:
>>>>>> "Andrew" == Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org> writes:
> 
> Andrew> --- a/gdb/gdbarch_components.py
> Andrew> +++ b/gdb/gdbarch_components.py
> Andrew> @@ -1675,6 +1675,7 @@ BFD target to use when generating a core file.
> Andrew>      predicate=True,
> Andrew>      predefault="0",
> Andrew>      printer="pstring (gdbarch->gcore_bfd_target)",
> Andrew> +    invalid=True
> 
> Super nit, but it's better to have a trailing comma here, because it
> means that future additions can be done without touching this line.

Actually, black adds it automatically in this case.

Simon


More information about the Gdb-patches mailing list