[PATCH v2] gdb/DAP Few bug fixes & Evaluate Array Watch vars

Tom Tromey tom@tromey.com
Thu Jun 22 14:06:01 GMT 2023


>>>>> "Simon" == Simon Farre via Gdb-patches <gdb-patches@sourceware.org> writes:

Simon> EvaluateResult does not need a name, just as what Tom pointed out in
Simon> previous review. It's only the *children* that need to be made sure that
Simon> their names are valid. An identifier for a variable, can't ever have an
Simon> integer as a name, anyhow (not as far as I am aware, no programming
Simon> languages allow for that).

FWIW Rust uses them as tuple field names, but in gdb I think they'd wind
up as string regardless.

Thanks for the patch, this is ok.
Approved-By: Tom Tromey <tom@tromey.com>

Tom


More information about the Gdb-patches mailing list