[PATCH 1/3] [gdb/testsuite] Use require in gdb.dwarf2/implptr.exp

Tom de Vries tdevries@suse.de
Sat Jun 17 10:30:21 GMT 2023


In test-case gdb.dwarf2/implptr.exp I noticed:
...
} elseif {![is_x86_like_target]} {
    # This test can only be run on x86 targets.
    unsupported "needs x86-like target"
    return 0
}
...

Use instead "require is_x86_like_target".

Tested on x86_64-linux.
---
 gdb/testsuite/gdb.dwarf2/implptr.exp | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/gdb/testsuite/gdb.dwarf2/implptr.exp b/gdb/testsuite/gdb.dwarf2/implptr.exp
index 70d86ddf19a..71fb1e443ef 100644
--- a/gdb/testsuite/gdb.dwarf2/implptr.exp
+++ b/gdb/testsuite/gdb.dwarf2/implptr.exp
@@ -19,6 +19,9 @@ load_lib dwarf.exp
 # This test can only be run on targets which support DWARF-2 and use gas.
 require dwarf2_support
 
+# This test can only be run on x86 targets.
+require is_x86_like_target
+
 standard_testfile .S
 set csrcfile ${testfile}.c
 set opts {}
@@ -27,10 +30,6 @@ if [info exists COMPILE] {
     # make check RUNTESTFLAGS='gdb.dwarf2/implptr.exp COMPILE=1 CC_FOR_TARGET=gcc\ -m32'
     set srcfile ${csrcfile}
     lappend opts debug optimize=-O2
-} elseif {![is_x86_like_target]} {
-    # This test can only be run on x86 targets.
-    unsupported "needs x86-like target"
-    return 0  
 }
 
 if {[prepare_for_testing "failed to prepare" ${testfile} $srcfile $opts]} {

base-commit: 6a4058a60683ea096683d441cb78e3ad686f134f
-- 
2.35.3



More information about the Gdb-patches mailing list