[PATCH] gdb/testsuite: Testing with the armflang compiler

Tom Tromey tom@tromey.com
Fri Jun 9 14:33:17 GMT 2023


>>>>> "Richard" == Richard Bunt via Gdb-patches <gdb-patches@sourceware.org> writes:

Richard> +	} elseif { [ regexp "\[fc\]lang.*warning.*'-fdiagnostics-color=never'" "$cppline"] } {

IMO it's mildly better to use {} around the regexp and avoid the
backslashes, like:

    [ regexp {[fc]lang.*warning.*'-fdiagnostics-color=never'} "$cppline"]

Anyway this looks good to me.

Approved-By: Tom Tromey <tom@tromey.com>

Tom


More information about the Gdb-patches mailing list