[PATCHv3] gdb: building inferior strings from within GDB

Tom Tromey tom@tromey.com
Fri Jun 9 13:41:41 GMT 2023


>>>>> "Andrew" == Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org> writes:

Andrew> Thanks for pointing this out.  I see what's going on here.

Andrew> What about this patch for fixing it?

Looks good to me.

If this idiom:

Andrew> +  const std::string setting ((const char *) argv[0]->contents ().data (),
Andrew> +			     type0->length ());

is needed elsewhere, then maybe a new function or value method would be good.
For a single use though it doesn't seem to matter.

Tom


More information about the Gdb-patches mailing list