[PATCH v2 1/9] Convert skip_altivec_tests to allow form

[Pedro Alves]

On 2023-01-24 11:02 p.m., Tom Tromey wrote:
> -if {![istarget "powerpc*"] || [skip_altivec_tests]} {
> +require allow_altivec_tests
> +if {![istarget "powerpc*"]} {
>      verbose "Skipping altivec abi tests."
>      return
>  }

I noticed that this transformation changed one thing -- we'd now run allow_altivec_tests,
and hence the compilation tests that allow_altivec_tests does, on all targets, while
before we wouldn't, since the istarget check used to be before the skip_altivec_tests check.

Functionally, it's the same, even though it slows down testing a tiny bit for non-powerpc targets.

In the end, you'd now added the patch that removes this istarget check in the last patch of the
series, so it's good as is, no need to change anything here.

I went to look whether the skip_power_isa_3_1_tests and skip_vsx_tests patches (patches #3 and #4) were
likewise affected (as those are similar and could also have the istarget check pushed
down), but in those you've kept the order:

 -if {![istarget "powerpc*-*-linux*"] || [skip_vsx_tests]} {
 +if {![istarget "powerpc*-*-linux*"]} {
      verbose "Skipping PowerPC test for corefiles with VSX registers."
      return
  }
 +require allow_vsx_tests

... so we're all good.

The whole series looks good to me.