[PATCH 1/4] [gdb/testsuite] Simplify gdb.base/unwind-on-each-insn.exp
Tom de Vries
tdevries@suse.de
Mon Jan 23 09:36:43 GMT 2023
On 1/19/23 11:46, Tom de Vries via Gdb-patches wrote:
> In test-case gdb.base/unwind-on-each-insn.exp, we try to determine the last
> insn in function foo.
>
> This in it self is fragile, as demonstrated by commit 91836f41e20 ("Powerpc
> fix for gdb.base/unwind-on-each-insn.exp").
>
> But the purpose of finding the last insn is to stop stepping in foo when
> arriving at that last insn.
>
> There is however no guarantee that:
> - the last insn is actually executed, nor
> - that the last insn is executed last, nor
> - that the last insn is executed once.
>
> Fix this by simplying the test-case to continue stepping till stepping out of
> foo.
>
I re-read the commit log, found it not clear enough, and decided to make
the difference between:
- last disassembled insn, and
- last insn executed before returning to main.
a bit more explicit.
Committed as attached.
Thanks,
- Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-gdb-testsuite-Simplify-gdb.base-unwind-on-each-insn..patch
Type: text/x-patch
Size: 3659 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/gdb-patches/attachments/20230123/ce9afdca/attachment-0001.bin>
More information about the Gdb-patches
mailing list