[PATCH 3/3] Let Python breakpoints be created silently

Eli Zaretskii eliz@gnu.org
Thu Jan 12 09:42:24 GMT 2023


> From: Tom Tromey <tromey@adacore.com>
> Cc: Tom Tromey <tromey@adacore.com>, Eli Zaretskii <eliz@gnu.org>
> Date: Wed, 11 Jan 2023 10:31:33 -0700
> 
> >>>>> "Tom" == Tom Tromey via Gdb-patches <gdb-patches@sourceware.org> writes:
> 
> Tom> Currently, a breakpoint created from Python will always announce its
> Tom> presence; and in some cases (for example a pending breakpoint), other
> Tom> information will be printed as well.
> 
> Tom> When scripting gdb, it's useful to be able to control the output in
> Tom> cases like this.  I debated whether to simply disable the output
> Tom> entirely, but I thought perhaps some existing code acts as a simple
> Tom> "break"-like command and wants the output.
> 
> Tom> This patch adds a new "announce" flag to gdb.Breakpoint.  Setting this
> Tom> to False will cause gdb to be silent here.
> 
> I think this one still needs a documentation review.

Sorry for missing it.

The patch is okay, with a single gotcha:

> +The optional @var{announce} argument is a boolean that controls
> +whether @var{GDBN} announces the existence of the breakpoint.  The
           ^^^^
That should be @value, not @var.


More information about the Gdb-patches mailing list