[PATCH] I'm debugging https://github.com/helix-editor/helix.git@63dcaae1b9083396fb3faaef9eaa2421f7e48fb9, which is a editor implemented with rust lang. When I type gdb command below: (gdb) b pars gdb dumped. I got: m_match = 0x7fffd8173cc7 "parse::h3bbecc5bbd82b347" m_ignored_ranges = { first = 0x7fffd8173cbb "<impl str>::parse::h3bbecc5bbd82b347", second = 0x7fffd8173cc5 "::parse::h3bbecc5bbd82b347" }

Tom Tromey tom@tromey.com
Thu Jan 5 20:24:42 GMT 2023


>>>>> "Zheng" == Zheng Zhan Liang via Gdb-patches <gdb-patches@sourceware.org> writes:

Zheng> From: Zheng Zhan <zzlossdev@163.com>

Hi.  Thank you for the patch.

The text all seemed to end up in the Subject line.  Probably you need
another newline after the first line of the commit message.

Zheng> --- a/gdb/completer.h
Zheng> +++ b/gdb/completer.h
Zheng> @@ -163,8 +163,11 @@ class completion_match_for_lcd
Zheng>  	const char *prev = m_match;
Zheng>  	for (const auto &range : m_ignored_ranges)
Zheng>  	  {
Zheng> -	    m_finished_storage.append (prev, range.first);
Zheng> -	    prev = range.second;
Zheng> +            if (prev < range.first)
Zheng> +              {
Zheng> +                m_finished_storage.append (prev, range.first);
Zheng> +                prev = range.second;
Zheng> +              }

Is there any way to construct a test case for this?

Tom


More information about the Gdb-patches mailing list