[PATCH v3 0/7] Small cleanups in array_operation::evaluate

[Simon Marchi]

On 8/29/23 14:10, Tom Tromey via Gdb-patches wrote:
> While working on another, larger, series, I found a few small cleanups
> to do in array_operation::evaluate.  I've made each one a separate
> patch to try to keep each one reasonably obvious.
> 
> Regression tested on x86-64 Fedora 36.
> 
> ---
> Changes in v3:
> - Use foreach in one method
> - Link to v2: https://inbox.sourceware.org/gdb-patches/20230829-cleanup-array-op-v2-0-3035458b0443@adacore.com
> 
> Changes in v2:
> - Added two more cleanup patches
> - Link to v1: https://inbox.sourceware.org/gdb-patches/20230828-cleanup-array-op-v1-0-12ca00f20917@adacore.com
> 
> ---
> Tom Tromey (7):
>       Use gdb::array_view for value_array
>       Declare 'tem' in loop header in array_operation::evaluate
>       Hoist array bounds check in array_operation::evaluate
>       Remove redundant variable from array_operation::evaluate
>       Remove another redundant variable from array_operation::evaluate
>       Remove "highbound" parameter from value_array
>       More renames in array_operation::evaluate
> 
>  gdb/eval.c      | 34 +++++++++++++---------------------
>  gdb/rust-lang.c |  2 +-
>  gdb/valops.c    | 24 +++++++++---------------
>  gdb/value.h     |  4 ++--
>  4 files changed, 25 insertions(+), 39 deletions(-)
> ---
> base-commit: aa7b36b832a1475fad2f184e0b4b58fb2f12241f
> change-id: 20230828-cleanup-array-op-49e3af3bd743
> 
> Best regards,
> -- 
> Tom Tromey <tromey@adacore.com>
> 

Approved-By: Simon Marchi <simon.marchi@efficios.com>

Thanks,

Simon