[PATCH 0/3] New gdb::make_unique and more std::unique_ptr use
Andrew Burgess
aburgess@redhat.com
Wed Aug 23 08:52:23 GMT 2023
Tom Tromey <tom@tromey.com> writes:
>>>>>> "Andrew" == Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org> writes:
>
> Andrew> This started while working on another series, in order to avoid
> Andrew> calling 'new' directly, I really wanted a std::make_unique function --
> Andrew> but that's C++14, so not available for GDB right now.
>
> Andrew> So I added a gdb::make_unique, which should be equivalent to the C++14
> Andrew> function.
>
> Andrew> The last two commits are additional make_unique/unique_ptr changes,
> Andrew> but target specific areas that needed slightly more refactoring.
>
> Thanks for doing this. I re-read the series & with your latest
> make_unique patch, it looks good to me.
>
> FWIW I think the ::make approach was just a sort of minimal refactoring
> at the time. Previously the constructor didn't do anything.
>
> Approved-By: Tom Tromey <tom@tromey.com>
Pushed.
Thanks,
Andrew
More information about the Gdb-patches
mailing list