[PATCH] Avoid buffer overflow in ada_decode

Keith Seitz keiths@redhat.com
Wed Aug 16 17:56:39 GMT 2023


On 8/16/23 10:31, Tom Tromey via Gdb-patches wrote:
> A bug report pointed out a buffer overflow in ada_decode, which Keith
> helpfully analyzed.  ada_decode had a logic error when the input was
> all digits.  While this isn't valid -- and would probably only appear
> in fuzzer tests -- it still should be handled properly.
> 
> This patch adds a missing bounds check.  Tested with the self-tests in
> an asan build.

That's excellent. Thank you for the quick turnaround!

Reviewed-by: Keith Seitz <keiths@redhat.com>

Keith



More information about the Gdb-patches mailing list