[PATCH] [gdb] Fix maint print symbols/psymbols help text

Eli Zaretskii eliz@gnu.org
Mon Aug 14 12:14:12 GMT 2023


> Date: Mon, 14 Aug 2023 10:53:40 +0200
> From: Tom de Vries via Gdb-patches <gdb-patches@sourceware.org>
> 
> diff --git a/gdb/psymtab.c b/gdb/psymtab.c
> index 64b67078641..bdae9db9676 100644
> --- a/gdb/psymtab.c
> +++ b/gdb/psymtab.c
> @@ -1687,7 +1687,7 @@ Entries in the partial symbol table are dumped to file OUTFILE,\n\
>  or the terminal if OUTFILE is unspecified.\n\
>  If ADDRESS is provided, dump only the file for that address.\n\
>  If SOURCE is provided, dump only that file's symbols.\n\
> -If OBJFILE is provided, dump only that file's minimal symbols."),
> +If OBJFILE is provided, dump only that object file's symbols."),
>  	   &maintenanceprintlist);
>  
>    add_cmd ("psymtabs", class_maintenance, maintenance_info_psymtabs, _("\
> diff --git a/gdb/symmisc.c b/gdb/symmisc.c
> index a65552aa2d2..5b8a82e5137 100644
> --- a/gdb/symmisc.c
> +++ b/gdb/symmisc.c
> @@ -1052,7 +1052,7 @@ Entries in the full symbol table are dumped to file OUTFILE,\n\
>  or the terminal if OUTFILE is unspecified.\n\
>  If ADDRESS is provided, dump only the file for that address.\n\
>  If SOURCE is provided, dump only that file's symbols.\n\
> -If OBJFILE is provided, dump only that file's minimal symbols."),
> +If OBJFILE is provided, dump only that object file's symbols."),
>  	   &maintenanceprintlist);
>  
>    add_cmd ("msymbols", class_maintenance, maintenance_print_msymbols, _("\

Thanks, this LGTM, but shouldn't the "ADDRESS" line be reworded like
below?

  If ADDRESS is provided, dump only the symbols for that address.

If that's not the intent, then can someone please explain the meaning
of "the file for that address"?


More information about the Gdb-patches mailing list