[PATCH v2 0/6] [gdb/symtab] Fix data-races in gdb.base/index-cache.exp

[Tom de Vries]

On 8/2/23 21:44, Tom Tromey wrote:
>>>>>> "Tom" == Tom de Vries via Gdb-patches <gdb-patches@sourceware.org> writes:
> 
> Thanks for this series.  I read through it and sent a few notes.
> 
> Tom> There's one more patch like that, I checked using pahole that the struct size
> Tom> is not increased.
> 
> "ptype/o" is basically pahole FWIW.
> 
> I tend to think that in most cases, the size of objects doesn't really
> matter.  I mean, obviously we don't want to bloat them unnecessarily,
> but for something like this, I just wouldn't worry much... and if we did
> care there's probably some other way we could shrink them than worrying
> about packing.
> 
> In the olden days pretty much the only thing really worth worrying about
> was partial symbols.  Now I guess it would be cooked_index_entry.

Ack.

I've submitted a v3, following up on comments and dropping the patch 
that's no longer required.

I'll commit tomorrow unless there are further comments.

Thanks,
- Tom