[PATCH 2/7] sim/cris: Add ATTRIBUTE_PRINTF

Tsukasa OI research_trasio@irq.a4lg.com
Sun Sep 25 08:44:12 GMT 2022


Clang generates a warning if the format string of a printf-like function is
not a literal ("-Wformat-nonliteral").  On the default configuration, it
causes a build failure (unless "--disable-werror" is specified).

To avoid warnings on the printf-like wrapper, it requires proper
__attribute__((format)) and we have ATTRIBUTE_PRINTF macro for this reason.

This commit adds ATTRIBUTE_PRINTF to a printf-like function.

sim/ChangeLog:

	* cris/traps.c (cris_unknown_syscall): Add ATTRIBUTE_PRINTF.
---
 sim/cris/traps.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sim/cris/traps.c b/sim/cris/traps.c
index 8750c4d4e3c..3cbbe4088e5 100644
--- a/sim/cris/traps.c
+++ b/sim/cris/traps.c
@@ -1382,7 +1382,7 @@ make_first_thread (SIM_CPU *current_cpu)
 /* Handle unknown system calls.  Returns (if it does) the syscall
    return value.  */
 
-static USI
+static USI ATTRIBUTE_PRINTF(3, 4)
 cris_unknown_syscall (SIM_CPU *current_cpu, USI pc, char *s, ...)
 {
   SIM_DESC sd = CPU_STATE (current_cpu);
-- 
2.34.1



More information about the Gdb-patches mailing list